search

berkeley-stat222 / mousestyles

2016 final project
http://berkeley-stat222.github.io/mousestyles/
BSD 2-Clause "Simplified" License
2 stars 33 forks source link

MRG: Add function for plotting paths #172

Closed togawa28 closed 8 years ago

togawa28 commented 8 years ago

Added the function to visualize paths in the original form. For details see #170. @jJasonWang please review.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.9%) to 60.025% when pulling f34af41f945188565cf5b68c31f923c55dff02da on togawa28:plot_path#170 into fe934f35e67546a66e3cc71c8f58aec6ea14211d on berkeley-stat222:master.

togawa28 commented 8 years ago

I've fixed styles by following advises of @jJasonWang. The coverage decreased because I didn't put any test functions: this is a function to make a plot and is difficult to be tested. Do you guys think we need some additional functionalities as discussed at the issue #170? If you all think we've done with this function and no more additional stuff, I'll change it to MRG.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.9%) to 62.187% when pulling c4a32be9dd36940061a0fba76dd86f2f500c118f on togawa28:plot_path#170 into f3ebe18c096676cddeba12a1e9089bc53dc2ea74 on berkeley-stat222:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-1.0%) to 62.115% when pulling 96478dc8ab1d306c4979bd4263dda448deff575d on togawa28:plot_path#170 into f3ebe18c096676cddeba12a1e9089bc53dc2ea74 on berkeley-stat222:master.

togawa28 commented 8 years ago

@jarrodmillman This is ready to merge. Discussions can be found in #170. Please review and pull if you think it's fine.

jarrodmillman commented 8 years ago

@togawa28 Could you add a plot to the report to show that this works? The instruction are in the README.md:

$ cat doc/source/report/README.md 
Notes
=====

For generating plots, please add a script that generates the desired plot
in `report/plots/example.py`.

Then add a directive like this in the file where you would like the figure
to appear:

``
.. plot:: report/plots/example.py

   Put your caption here.
``

Once you've done that (it should be trivial to add), rebase and change this back to MRG.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.04%) to 63.143% when pulling 5327144a369089699c0273c6d9be9b4364155626 on togawa28:plot_path#170 into f3ebe18c096676cddeba12a1e9089bc53dc2ea74 on berkeley-stat222:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.04%) to 63.143% when pulling 0d6cbd2571fad209fa2c6eaaccd15b3e341a09a9 on togawa28:plot_path#170 into f3ebe18c096676cddeba12a1e9089bc53dc2ea74 on berkeley-stat222:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.04%) to 63.143% when pulling 0d6cbd2571fad209fa2c6eaaccd15b3e341a09a9 on togawa28:plot_path#170 into f3ebe18c096676cddeba12a1e9089bc53dc2ea74 on berkeley-stat222:master.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.04%) to 63.143% when pulling 62265f5371400ab5aedcfa473f75c68da077d68f on togawa28:plot_path#170 into f3ebe18c096676cddeba12a1e9089bc53dc2ea74 on berkeley-stat222:master.

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-1.0%) to 63.143% when pulling 2cc68ad9650d95ec7ab75ef58bc67ff702993d2e on togawa28:plot_path#170 into 100f5947a55d2e11c891266685e15775c99aa67e on berkeley-stat222:master.

togawa28 commented 8 years ago

@jarrodmillman I added .py file in plots folder, modified path.rst file, and rebased it. I'm not sure why, but my .rst file does not show my plot, although .py file looks working fine. Except for that, it's ready to merge so the title is changed to MRG.