berkeley-stat222 / mousestyles

2016 final project
http://berkeley-stat222.github.io/mousestyles/
BSD 2-Clause "Simplified" License
2 stars 33 forks source link

MRG: Project 3 Add get_score function along with its test function to evaluate the simulation #176

Closed wyshi closed 8 years ago

wyshi commented 8 years ago

Hello guys, I just add the get_score function to evaluate the performance of the simulation. Please review and leave some comments! Thanks. related to issue #166 @HongfeiZhao @Chenyu-Renee @harryh1993 @mingyungkim @lynnzhao

coveralls commented 8 years ago

Coverage Status

Coverage increased (+1.3%) to 62.304% when pulling 8acc3bf04d49385602730d8d15a677480c0b2573 on wyshi:subproject-issue#166 into fe934f35e67546a66e3cc71c8f58aec6ea14211d on berkeley-stat222:master.

HongfeiZhao commented 8 years ago

Looks great to me. Please check others' comments.

wyshi commented 8 years ago

Hello guys, I have modified the file based on the comments. Any thoughts before I change it to MRG? @HongfeiZhao @harryh1993 @lynnzhao92 @mingyungkim @Chenyu-Renee

coveralls commented 8 years ago

Coverage Status

Coverage increased (+3.3%) to 64.258% when pulling 893c1cbd98b0c837a49817fd2b79d1323001c321 on wyshi:subproject-issue#166 into fe934f35e67546a66e3cc71c8f58aec6ea14211d on berkeley-stat222:master.

harryh1993 commented 8 years ago

Seems pretty good for me

lynnzhao92 commented 8 years ago

Looks great! I think we are ready to merge!

wyshi commented 8 years ago

@jarrodmillman Hello Jarrod, this pull request is ready to merge. The group members have reviewed it. Please review and merge it. Thanks!

jarrodmillman commented 8 years ago

@wyshi I am working with your teammates @lynnzhao92 and @HongfeiZhao . We wanted to rebase this quickly, so I cherry-picked your commits and made a new pull request #182 . I am closing this and will merge the new one with your changes.