berkeley-stat222 / mousestyles

2016 final project
http://berkeley-stat222.github.io/mousestyles/
BSD 2-Clause "Simplified" License
2 stars 33 forks source link

MRG: add time interval functions and test #185

Closed lynnzhao92 closed 8 years ago

lynnzhao92 commented 8 years ago

please review @HongfeiZhao , @wyshi, @mingyungkim

coveralls commented 8 years ago

Coverage Status

Changes Unknown when pulling 759924a706c7dc67847a7b762cab8e1439b59072 on lynnzhao92:time_interval_dynamics into \ on berkeley-stat222:master**.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+1.2%) to 65.577% when pulling 3e691cbb5d0535607ad088ce0ec20e73a2bedef2 on lynnzhao92:time_interval_dynamics into 67bdb6692f6e64d54dd63ce3edb7480eb4a1d6a3 on berkeley-stat222:master.

jarrodmillman commented 8 years ago

@lynnzhao92 please rebase this on berkeley-stat222 master and I will merge it.

lynnzhao92 commented 8 years ago

done rebase. please check @jarrodmillman

lynnzhao92 commented 8 years ago

I have this error reported: from matplotlib.backends import _macosx E RuntimeError: Python is not installed as a framework. The Mac OS X backend will not be able to function correctly if Python is not installed as a framework. See the Python documentation for more information on installing Python as a framework on Mac OS X. Please either reinstall Python as a framework, or try one of the other backends. If you are Working with Matplotlib in a virtual enviroment see 'Working with Matplotlib in Virtual environments' in the Matplotlib FAQ

@jarrodmillman do you know how to fix that?

jarrodmillman commented 8 years ago

@lynnzhao92 According to TravisCI the test failure appears to be due to trailing whitespace in mousestyles.dynamics.__init__.py. That should be an easy fix.

I am not sure where the Mac errors are coming from. Are you seeing them on your laptop? If so, maybe you have something wrong with your matplotlib installation. If you bring it to me, I can take a look.

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.9%) to 73.306% when pulling aa1e9ad95e1a59a92be57c598450ffce2875e5e7 on lynnzhao92:time_interval_dynamics into e5f1b77849e34e8dd5951ff7faa2b77e32a056f1 on berkeley-stat222:master.

mingyungkim commented 8 years ago

@jarrodmillman Hello Jarrod, this pull request is ready to merge. The group members have reviewed it. Please review and merge it. Thanks!