search

berkeley-stat222 / mousestyles

2016 final project
http://berkeley-stat222.github.io/mousestyles/
BSD 2-Clause "Simplified" License
2 stars 33 forks source link

MRG: add kernel estimation and relative distribution for power law project #199

Closed FengshiNiu closed 8 years ago

FengshiNiu commented 8 years ago

Contributing issue #193. Add gaussian kernel estimation of the distance distribution, add the estimated distribution to the plots in the review. @doutib @hduongtrong @CenzhuoYao @z357412526 @lunadadada please review

FengshiNiu commented 8 years ago

@shamindras could you please do a quick code review?

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 77.872% when pulling 3d162290826c97dd70dc4bd9cd71266f496169b2 on FengshiNiu:contributing-issue#193 into 1f5b550411fff2c69d7745aabc924222837a088c on berkeley-stat222:master.

shamindras commented 8 years ago

@FengshiNiu - just did a code review. Make sure all Travis tests pass before addressing any suggested changes

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 77.872% when pulling 3d162290826c97dd70dc4bd9cd71266f496169b2 on FengshiNiu:contributing-issue#193 into 1f5b550411fff2c69d7745aabc924222837a088c on berkeley-stat222:master.

FengshiNiu commented 8 years ago

@shamindras thanks for the comments. These are really good suggestions for coding style. I have just modified the code

coveralls commented 8 years ago

Coverage Status

Coverage increased (+0.2%) to 77.092% when pulling aed9899f2dd8839a9ccca2d6bc8c1f199cd7afd8 on FengshiNiu:contributing-issue#193 into d82e0940cdfd809b458308c6e75c982d49593138 on berkeley-stat222:master.

jarrodmillman commented 8 years ago

@FengshiNiu When you are ready for me to merge this, rebase to upstream master and change the title to MRG from WIP.

FengshiNiu commented 8 years ago

Sure. I am still working on it and will change to MRG as soon as I finish it

On Fri, May 13, 2016 at 11:34 PM, Jarrod Millman notifications@github.com wrote:

@FengshiNiu https://github.com/FengshiNiu When you are ready for me to merge this, rebase to upstream master and change the title to MRG from WIP.

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/berkeley-stat222/mousestyles/pull/199#issuecomment-219204076

Fengshi Niu PhD student Department of Economics University of California, Berkeley fniu@berkeley.edu

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.3%) to 77.921% when pulling cda64ba0e7f42212873c1a2bb602e2b546c15a9f on FengshiNiu:contributing-issue#193 into 7c257a82cb04cf60fc3cdb11ab8de4a0ab861f58 on berkeley-stat222:master.

FengshiNiu commented 8 years ago

@jarrodmillman ready to merge!

jarrodmillman commented 8 years ago

@FengshiNiu Please rebase on the upstream master and I will merge this. Let me know if you don't know how to rebase and I will do it for you.

Also did the your results (from this code) make into the report?

FengshiNiu commented 8 years ago

@jarrodmillman I am finishing adding results in the report now.

FengshiNiu commented 8 years ago

@jarrodmillman I wil add the modification of report in this pull request

jarrodmillman commented 8 years ago

@FengshiNiu OK

FengshiNiu commented 8 years ago

@shamindras Thank you very much for help

FengshiNiu commented 8 years ago

@jarrodmillman I have just added the result to the report. I tried hard but the 2 plots don't show up. Could you have a look at it? The plot script called are report/plots/plot_kernel_smoothing.py and report/plots/plot_relative_distribution.py

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.3%) to 77.996% when pulling 322bc3a994a8fed67c057a25137acaca2db6de7f on FengshiNiu:contributing-issue#193 into 6abcc51e1e8faac9e021a7256b606c3c7d815f6f on berkeley-stat222:master.

jarrodmillman commented 8 years ago

@FengshiNiu When I do the following

$ cd doc/source
$ make html

your plots are generated and included in the generated HTML. I suspect that you may have something misconfigured on your computer or that you are expecting GitHub to know how to generate figures using the code in our repository (GitHub doesn't render things based on the code in our project, but using their own code which may not have all the functionality our code has).

This looks OK to merge once the tests finish. If you want me to wait for you to do something else, please let me know. Otherwise, I will merge this once the tests complete (assuming they pass).

FengshiNiu commented 8 years ago

Thanks for the clarification. I've finished the work. It's ready to merge if it passes the tests.

On Saturday, May 14, 2016, Jarrod Millman notifications@github.com wrote:

@FengshiNiu https://github.com/FengshiNiu When I do the following

$ cd doc/source $ make html

your plots are generated and included in the generated HTML. I suspect that you may have something misconfigured on your computer or that you are expecting GitHub to know how to generate figures using the code in our repository (GitHub doesn't render things based on the code in our project, but using their own code which may not have all the functionality our code has).

This looks OK to merge once the tests finish. If you want me to wait for you to do something else, please let me know. Otherwise, I will merge this once the tests complete (assuming they pass).

— You are receiving this because you were mentioned. Reply to this email directly or view it on GitHub https://github.com/berkeley-stat222/mousestyles/pull/199#issuecomment-219237126

Fengshi Niu PhD student Department of Economics University of California, Berkeley fniu@berkeley.edu

coveralls commented 8 years ago

Coverage Status

Coverage decreased (-0.3%) to 77.996% when pulling 322bc3a994a8fed67c057a25137acaca2db6de7f on FengshiNiu:contributing-issue#193 into 6abcc51e1e8faac9e021a7256b606c3c7d815f6f on berkeley-stat222:master.