Modify test_apply_lane_change_direction()

berkeleyflow / flow

MIT License

14 stars 4 forks source link

Modify test_apply_lane_change_direction() #30

Open fywu85 opened 6 years ago

fywu85 commented 6 years ago

The current test_apply_lane_change_direction() in tests/fast_tests/test_environment_base_class.py may fail with a 60% change due to the default fail-safe lane change mode in SUMO. Suggest to rewrite this unit test so that it can pass with certainty.

Consider either change assertion condition or enforce lane change command by traci_connection.vehicle.setLaneChangeMode(vehID, 0).

AboudyKreidieh commented 6 years ago

no way for me to test this (I don't get the bug). The solution is sound though, the test is just meant to ensure that if you ask from a lane changes via apply_lane_change(), then sumo at least tries to process the command. @fywu85 if you want to fix this up and make sure it works for you as well I'd be happy to approve this.