search

berkerpeksag / astor

Python AST read/write
https://pypi.org/project/astor/
BSD 3-Clause "New" or "Revised" License
810 stars 102 forks source link

Support python 3.7 docstrings #102

Closed radomirbosak closed 6 years ago

radomirbosak commented 6 years ago

This fixes the change in python API introduced by https://bugs.python.org/issue29463

Fixes #101.

radomirbosak commented 6 years ago

@berkerpeksag I addressed the comments. PTAL

radomirbosak commented 6 years ago

Rebased to master after merging #103 . Added attributions.

berkerpeksag commented 6 years ago

I'm planning to release 0.7.0 next week. Do you have time to add some tests? I can take over and finish this PR if you don't have time.

radomirbosak commented 6 years ago

I added a test for the docstring fix (which fails on current master, but passes on this proposed branch). Are any more tests needed?

And sorry that addressing your comments took so long. I didn't have much time last week.

radomirbosak commented 6 years ago

Note the changes from today are in form of fixup commits, which need to be squashed before merging.

radomirbosak commented 6 years ago

I added the tests for class and method docstrings and then one for module docstrings too.

berkerpeksag commented 6 years ago

Merged in https://github.com/berkerpeksag/astor/commit/524d525e999f98198787bb35d0b18d83cfa25d4a and https://github.com/berkerpeksag/astor/commit/f87ae3b55f9ea403b4c04fb6cd9b0ab675aaa496. Thanks!