Closed Kodiologist closed 5 years ago
I guess the cause of the failure is that something has changed in the development version of Python. Also, our Travis configuration seems wrong, because the following lines were supposed to make the build for 3.8-dev passed in case of a failure:
I removed those lines in this PR, because I expected the build to pass. And I think I'm using the same version of Python 3.8.
@berkerpeksag Okay, all should be good now.
Also, I usually use the "squash and merge" option, but let me know if you'd like to keep these commits separated.
feel free to submit a separate PR (or use this one if you prefer) to add Python 3.8 to trove classifiers and update other places (I can't remember if there's more places we need to update :))
I've updated the trove classifiers, but I can't remember anything else that needs to be changed, either.
Also, I usually use the "squash and merge" option, but let me know if you'd like to keep these commits separated.
It's more your project than mine, but my philosophy has always been that it's easier to read history in bite-sized chunks.
Thank you!
I'm not sure what to make of the test failures on Travis.
nosetests --nocapture
passes on my own machine (running Ubuntu 18.10) with Python 3.8.0a2.