search

berkerpeksag / astor

Python AST read/write
https://pypi.org/project/astor/
BSD 3-Clause "New" or "Revised" License
803 stars 102 forks source link

Python 3.8 fixes #133

Closed Kodiologist closed 5 years ago

Kodiologist commented 5 years ago

I'm not sure what to make of the test failures on Travis. nosetests --nocapture passes on my own machine (running Ubuntu 18.10) with Python 3.8.0a2.

berkerpeksag commented 5 years ago

I guess the cause of the failure is that something has changed in the development version of Python. Also, our Travis configuration seems wrong, because the following lines were supposed to make the build for 3.8-dev passed in case of a failure:

https://github.com/berkerpeksag/astor/blob/641390339bea88f13bcdd0abaa576e078191a86c/.travis.yml#L20-L21

Kodiologist commented 5 years ago

I removed those lines in this PR, because I expected the build to pass. And I think I'm using the same version of Python 3.8.

Kodiologist commented 5 years ago

@berkerpeksag Okay, all should be good now.

berkerpeksag commented 5 years ago

Also, I usually use the "squash and merge" option, but let me know if you'd like to keep these commits separated.

Kodiologist commented 5 years ago

feel free to submit a separate PR (or use this one if you prefer) to add Python 3.8 to trove classifiers and update other places (I can't remember if there's more places we need to update :))

I've updated the trove classifiers, but I can't remember anything else that needs to be changed, either.

Also, I usually use the "squash and merge" option, but let me know if you'd like to keep these commits separated.

It's more your project than mine, but my philosophy has always been that it's easier to read history in bite-sized chunks.

berkerpeksag commented 5 years ago

Thank you!