search

berkerpeksag / astor

Python AST read/write
https://pypi.org/project/astor/
BSD 3-Clause "New" or "Revised" License
803 stars 102 forks source link

Fix packaging for setuptools>=41.4 #163

Closed jonringer closed 4 years ago

jonringer commented 4 years ago

setup(**config['options']) is no longer valid, see https://github.com/berkerpeksag/astor/issues/162 for error

closes https://github.com/berkerpeksag/astor/issues/162

jonringer commented 4 years ago

bump @berkerpeksag @isidentical

mukkid commented 4 years ago

What is the status of this PR? @jonringer @berkerpeksag

jonringer commented 4 years ago

it's ready to merge from my standpoint, and passes CI

jonringer commented 4 years ago

had to modify the MANIFEST so that it exported the VERSION file when building a distribution, otherwise it would fail to open when installed

jonringer commented 4 years ago

looks like i had had a stale branch on my other computer, had to re-apply the Path -> os.path changes.

larstiq commented 4 years ago

Looks good to me fwiw. Are there co-maintainers to take this forward if @berkerpeksag doesn't have time?

jonringer commented 4 years ago

bump

paulbors commented 4 years ago

Please merge this fix in.

berkerpeksag commented 4 years ago

Thanks for the PR and sorry for my late response! I've been dealing with a lot of $LIFE stuff lately. I'll add a note to changelog and release 0.8.1 hopefully tomorrow.

jonringer commented 4 years ago

@berkerpeksag I completely understand, :)

berkerpeksag commented 4 years ago

0.8.1 is now published on PyPI: https://pypi.org/project/astor/0.8.1/