search

berkerpeksag / astor

Python AST read/write
https://pypi.org/project/astor/
BSD 3-Clause "New" or "Revised" License
803 stars 102 forks source link

Use issubclass instead of isinstance to compare SourceGenerator in to_source #164

Closed willcrichton closed 4 years ago

willcrichton commented 4 years ago

I believe this is just a bug. If source_generator_class is a class, then isinstance is not appropriate since it's a class, not a class instance/object.

willcrichton commented 4 years ago

Should I make a new section (0.9.0) in the changelog for the release note?

berkerpeksag commented 4 years ago

Should I make a new section (0.9.0) in the changelog for the release note?

Yes, that would be great! Actually, we can even make it 0.8.1 for now.

berkerpeksag commented 4 years ago

BTW, I just merged a PR that adds a new section for 0.8.1. You can now rebase your branch and add a new entry for this PR.

berkerpeksag commented 4 years ago

Thank you!