search

berkerpeksag / astor

Python AST read/write
https://pypi.org/project/astor/
BSD 3-Clause "New" or "Revised" License
793 stars 101 forks source link

Generalize VERSION file processing #176

Closed foreignmeloman closed 3 years ago

foreignmeloman commented 4 years ago

bd2b512 fixes the case when setup script can not process file:astor/VERSION instruction and parses it like file-astor-VERSION

cf33f40 fixes a rare case when python can not use open() to read contents of a file packed in an egg archive.

33b5c81 removes astor/VERSION file and moves version info into an attribute.

foreignmeloman commented 4 years ago

Thanks! I hope I got your idea correctly, regarding the astor/VERSION file.

File setuputils.py can also be removed in the future as there's no use for it anymore.

Regarding the failing test on Travis I have no idea what's causing it, but I think it's not my change since the same exact test also fails for #175. Please correct me if I'm wrong.

berkerpeksag commented 4 years ago

Thanks! I hope I got your idea correctly, regarding the astor/VERSION file.

Yes, that's exactly what I meant, thanks!

File setuputils.py can also be removed in the future as there's no use for it anymore.

We can remove it now if you have some free time :)

Regarding the failing test on Travis I have no idea what's causing it, but I think it's not my change since the same exact test also fails for #175.

Yes, you're right. We can ignore PyPy tests for now.

foreignmeloman commented 4 years ago

We can remove it now if you have some free time :)

Done in 12b6a47 :)