search

berkerpeksag / astor

Python AST read/write
https://pypi.org/project/astor/
BSD 3-Clause "New" or "Revised" License
810 stars 102 forks source link

Use tox-travis #56

Closed refi64 closed 7 years ago

refi64 commented 7 years ago

Makes it a little simpler IMO (but feel free to reject if you feel otherwise!).

refi64 commented 7 years ago

Also, the tests on #54, #55, and #57 are all failing due to PyPy3 being too old, which this also fixes.

berkerpeksag commented 7 years ago

Thanks! It looks like pypy3-5.5.0 doesn't build correctly:

pypy3-5.5.0 is not installed; attempting download
Downloading archive: https://s3.amazonaws.com/travis-python-archives/binaries/ubuntu/12.04/x86_64/pypy3-5.5.0.tar.bz2
$ sudo tar xjf pypy3-5.5.0.tar.bz2 --directory /
bzip2: (stdin) is not a bzip2 file.
tar: Child returned status 2
tar: Error is not recoverable: exiting now
The command "sudo tar xjf pypy3-5.5.0.tar.bz2 --directory /" failed and exited with 2 during .
Your build has been stopped.

https://travis-ci.org/berkerpeksag/astor/jobs/208328669

refi64 commented 7 years ago

Sounds like a Travis issue, since the tox-travis code never actually does anything like that... I'll try restarting the build.

refi64 commented 7 years ago

Trying it again...

berkerpeksag commented 7 years ago

It looks like the new PyPy is still ages behind of CPython:

$ python --version
Python 3.3.5 (619c0d5af0e5, Oct 08 2016, 21:08:33)
[PyPy 5.5.0-alpha0 with GCC 4.8.2]

I don't really care about PyPy and I wouldn't want to add special cases to tox.ini or .travis.yml in order to get new PyPy work. I'd say drop the new PyPy part for now.

refi64 commented 7 years ago

Only problem is, the original PyPy3 now fails all the tests because it's too old for pip to work...

refi64 commented 7 years ago

@berkerpeksag HAHA, I didn't even need PyPy3 5.5...5.2 worked perfectly. Just...wow.

Anyway, the build works perfectly now. I squashed all the excess commits I had done while testing things out.

refi64 commented 7 years ago

@berkerpeksag Done!

refi64 commented 7 years ago

@berkerpeksag Bump...

berkerpeksag commented 7 years ago

Did you see my comment about quotes around Python versions? If you can replace "X.Y" with X.Y I can merge it today. Thanks!

refi64 commented 7 years ago

And I mentioned that the quotes can only be dropped on the PyPy ones, which I already did, otherwise YAML will pick them up as a number... ;)

berkerpeksag commented 7 years ago

It seems like you're making your own rules. X.Y was valid for ages and I couldn't find any reference that says I should use "X.Y" instead of X.Y. Both Travis CI linter and build passed for me when I removed the quotes. I don't care how YAML parses them as long as Travis CI works.

refi64 commented 7 years ago

@berkerpeksag Haha...uhh...I...well, that was embarrassing. :O (I swear, I thought I tried that once and it didn't work? Must've been mixing up Travis with something else...)

How 'bout we just pretend that entire discussion never happened...

berkerpeksag commented 7 years ago

Thanks!