Clean up recent commits

berkerpeksag / astor

Python AST read/write

https://pypi.org/project/astor/

BSD 3-Clause "New" or "Revised" License

810 stars 102 forks source link

Clean up recent commits #60

Closed pmaupin closed 7 years ago

pmaupin commented 7 years ago

also run extended test cases via astor.rtrip
add regression tests for new features based on rtrip failures
fix failing regressions

pmaupin commented 7 years ago

I tried, maybe I'm too stupid. I'll spend a bit more time on it...

pmaupin commented 7 years ago

Ah. I've never done a force push before. I feel so dirty now. But the repo looks better. I'm happy with it; but we should make sure we understand why Ryan wanted those parentheses before we merge.

Thanks, Pat

pmaupin commented 7 years ago

@kirbyfan64 -- please look this over.

Thanks, Pat

pmaupin commented 7 years ago

OK, I found he really does need the extra parentheses.

And I found another issue -- need to set the precedence so tuples on the RHS get parentheses as well.

Fixed now.