Closed xnt closed 5 years ago
It is indeed =) First of all when it cannot find a user, it should return a 404 not a 505 and this itself can be a separate issue. And for organizations, first we have to make sure all the functionality for users are provided and then we MAY be able to implement it. Thanks for reporting and watch this issue for changes ;)
Still a bit dirty but I managed to do something similar with jQuery. Gotta clean it up, certainly, but hope it helps as a guide when you want to implement it here: https://github.com/xnt/jq_gh_org_badge
After @berkerpeksag's warning I realized that we used to support organizations indirectly since GitHub API allows querying them via /users/orgname too. Though it seems they have some inconsistencies about this. We have notified GitHub about the issue and waiting for their response.
+1 Support for organizations would be great!
The error will be fixed I guess but organizations are essentially different from regular users so we may have to adjust some parts to be able to get compatible with organizations. Also, if we check for a user first and then for the organization, there may be collisions. What do you say @berkerpeksag?
Again feel free to fork the project I posted and move it to python. I think the basic logic for getting the org data and its related users is there.
@xnt It is not about getting the org data. It is about merging them into a consistent product.
+1 For support for organisations.
We have much better support for organizations now:
See https://github.com/berkerpeksag/github-badge/issues/73#issuecomment-484919703 for details.
Closing this for now. Thank you for the feedback!
When I use an organization instead of a user, it throws a 500 server error... I guess this is more of a feature request than a bug itself, but it'd be nice having it...