search

berkerpeksag / github-badge

GitHub Badge is a simple embeddable badge showing your GitHub stats like the number of public repositories, number of followers, favorite languages etc.
https://githubbadge.appspot.com/
289 stars 31 forks source link

frameBorder is obsolete #53

Closed haf closed 12 years ago

haf commented 12 years ago

HTML validator sayz:

Line 87, Column 140: The frameborder attribute on the iframe element is obsolete. Use CSS instead.

…adge/haf?a=0' style='border: 0;height: 142px;width: 200px;overflow: hidden;' />
haf commented 12 years ago

...also, you might need to insert   in the iframe to avoid 'unclosed iframe element' due to 'ignoring />, treating as start of tag', in HTML5/Jekyll (dunno which to blame).

BYK commented 12 years ago

Iframe tag style is legit, I can confirm that. And for frameBorder, as you can see from the code, we already use border: 0 in the style attribute but IE7 (and may be IE8 too) needs frameBorder=0 to remove the border.