search

berkerpeksag / github-badge

GitHub Badge is a simple embeddable badge showing your GitHub stats like the number of public repositories, number of followers, favorite languages etc.
https://githubbadge.appspot.com/
291 stars 31 forks source link

Disabling Google Analytics didn't work #68

Closed cketti closed 10 years ago

cketti commented 10 years ago

Disabling Google Analytics didn't work because the variable 'analytics' in BadgeHandler.get() contained the string '0' when the appropriate GET parameter was sent. Therefore, '{% if analytics %}' in the template always evaluated to True and Google Analytics was included. This change also introduces stricter input validation for the GET parameters 's' and 'a'.

berkerpeksag commented 10 years ago

Fixed in https://github.com/berkerpeksag/github-badge/commit/ce33343abd37ae30c66f8811cbd69bc20c59627b. Thanks for the patch, @cketti!

cketti commented 10 years ago

When will you deploy this fix on https://githubbadge.appspot.com/ ?

berkerpeksag commented 10 years ago

Ah, sorry, deployed now. Thanks again.

cketti commented 10 years ago

Thank you for this wonderful project and your fast response!