berkgoksel / SierraOne

Shared reverse shell over Discord
GNU General Public License v3.0
127 stars 20 forks source link

Undefined Variable #4

Closed Arszilla closed 4 years ago

Arszilla commented 4 years ago

https://github.com/berkgoksel/SierraOne/blob/0941f8b383b7f30c8cdc7adc6157aea294b7f6ef/SierraOne.py#L250 filename is not a defined variable.

However, there are several mentions of filename in other functions. Most notably: https://github.com/berkgoksel/SierraOne/blob/0941f8b383b7f30c8cdc7adc6157aea294b7f6ef/SierraOne.py#L211

Please do not push the fix to the master. Instead, paste it here. I'll be pushing it to evaluation alongside my changes.

berkgoksel commented 4 years ago

You could add the following lines: Line11: \n Line12: filename = "output.txt" Line297: global filename

Next, remove every instance of filename in function definitions and function calls.

umtdg commented 4 years ago

Line 250 is supposed to be executed after line 211. So the fix should be:

Line 210: filename = "output.txt" Line 211: await channel.send("Output is too large. Will be send as file: {}".format(filename)) and the rest is the same.

Also please remove the line 250.

Arszilla commented 4 years ago

I'll apply the fix after #5 is passed onto master.

berkgoksel commented 4 years ago

Fixed.