search

berkmancenter / namae

Namae (名前) parses personal names and splits them into their component parts.
160 stars 32 forks source link

Fails to detect name parts with asterisk in name #13

Closed scarver2 closed 6 years ago

scarver2 commented 9 years ago

namae = Namae.parse('Gump *, Bubba') returns empty array instead of [#<Name family="Gump *" given="Bubba">]

aaronchi commented 8 years ago

Doesn't work with numerics either. Would be nice if special chars/numbers were treated the same as UCASE words to ensure that the parser doesn't die on unusual data.

inukshuk commented 8 years ago

If we do that it's very hard to tell, after the fact, whether or not the parser recognized a name -- this seems to be very much like swallowing errors: it may seem convenient, but an error is an error, and usually it's easier to deal with it where it occurs.