search

berkmancenter / namae

Namae (名前) parses personal names and splits them into their component parts.
159 stars 32 forks source link

Sort Order Breaks on Suffixes #4

Closed jonlhouse closed 9 years ago

jonlhouse commented 9 years ago

Version 0.9.1 seems to incorrectly parse names with suffiexs when parsed in "sort ordering".

E.g.

Namae.parse("Griffey, Ken Jr")  # => nil
inukshuk commented 9 years ago

Looking at our suffix test cases I think we never supported this syntax, but only "Griffey, Jr., Ken" or "Griffey, Ken, Jr.". Having said that, we definitely need to add support to this to the grammar, thanks for spotting it!

inukshuk commented 9 years ago

Fixed in 0.9.2

jonlhouse commented 9 years ago

Thanks.