v 1.1.0 can't parse the name correctly, as it was in previous versions

berkmancenter / namae

Namae (名前) parses personal names and splits them into their component parts.

159 stars 32 forks source link

v 1.1.0 can't parse the name correctly, as it was in previous versions #41

Closed IgorKhlebnikoff closed 3 years ago

IgorKhlebnikoff commented 3 years ago

::Namae.parse("Tom Van de Weghe") => [] ::Namae.parse("Tom Van De Weghe") => [] ::Namae.parse("tom van de weghe") =>[#<Name family="weghe" particle="tom van de">]

inukshuk commented 3 years ago

Thanks!

@lostmahbles it's probably best to simplify handling of particles. See my commit above and let me know if this looks good to you. Basically, I'm completely ignoring dropping particles for the time being (there's more effort necessary to support them properly) and the include_particle_in_family option applies to all particles now.

inukshuk commented 3 years ago

@IgorKhlebnikoff should be fixed in 1.1.1.