search

berkshelf / ridley

A reliable Chef API client with a clean syntax
Other
231 stars 84 forks source link

Fix for numeric and boolean attribute types. #245

Closed slantview closed 10 years ago

slantview commented 10 years ago

See https://tickets.opscode.com/browse/CHEF-4075 and https://github.com/opscode/chef/pull/1245

KAllan357 commented 10 years ago

I didn't realize we even had this code in Ridley. Can we add a test to verify this?

slantview commented 10 years ago

@KAllan357 Well it was already being tested, I suppose I could add detailed testing for each type.

reset commented 10 years ago

Aside from @ivey's catch in #validate_choice_array this looks good to me. I'm surprised that this wasn't already a thing in Chef.

slantview commented 10 years ago

Fixed tests. Still not sure why when I run thor spec:unit I don't see this test run.

reset commented 10 years ago

@slantview it's because the file needs to end with _spec.rb

KAllan357 commented 10 years ago

I'm :+1: after the styling changes and clarification on ruby version.

ivey commented 10 years ago

:+1:

will merge when Travis is green