search

berkshelf / ridley

A reliable Chef API client with a clean syntax
Other
230 stars 84 forks source link

Add NodeObject#unset_node_attribute #247

Closed capoferro closed 10 years ago

capoferro commented 10 years ago

I need this so I can unset a node specific setting and allow the default level attributes to take effect.

slantview commented 10 years ago

This looks pretty reasonable to me. Is there something specific this is for?

capoferro commented 10 years ago

Removing service state attributes so the environment (or cookbook) default attribute is respected.

For instance, when we disable a node, we set the service attributes to "stop". When we reenable, we want to remove the node specific "stop".

KAllan357 commented 10 years ago

Discussed how EnvironmentObject has similar code, but no type checking, so @bluepojo was going to update that.

:+1: on this change though.

capoferro commented 10 years ago

re: @KAllan357's comment, See #248

reset commented 10 years ago

:+1: