search

berkshelf / ridley

A reliable Chef API client with a clean syntax
Other
231 stars 84 forks source link

Fix scary error messages and hangs #249

Closed jbgo closed 10 years ago

jbgo commented 10 years ago

Fixes issue #220 when using celluloid/celluloid/b9c73fd1c73fb05733cd9f46910ada0d796b8e6c or later

sethvargo commented 10 years ago

@reset I feel like we did this already?

jbgo commented 10 years ago

I just installed ridley (v2.5.0) for the first time today. Is it possible you have a fix in another branch?

sethvargo commented 10 years ago

@jbgo sorry. I wasn't criticizing your fix. I was certain that we added the task_thread declarations. Just trying to figure out if we missed one or if there was a bad merge.

reset commented 10 years ago

@sethvargo the task_thread was changed for Connection to prevent blowing the stack on large responses. This modification would change the task_class for every actor to being a thread instead of a fiber which isn't what we want.

reset commented 10 years ago

A more permanent solution was applied to the master branch. Thanks @jbgo!

josephholsten commented 10 years ago

Woo!