berkshelf / ridley

A reliable Chef API client with a clean syntax
Other
230 stars 84 forks source link

Ensure a default constraint #265

Closed sethvargo closed 10 years ago

sethvargo commented 10 years ago

I don't think this fixes https://github.com/berkshelf/berkshelf/issues/1135... I actually don't see how that issue is even possible...

reset commented 10 years ago

@sethvargo we're already checking for a nil or blank string in the initializer of Semverse::Constraint. I don't think this code does anything

sethvargo commented 10 years ago

For reference, ya: https://github.com/berkshelf/semverse/blob/a91bde2e15b58223a6a0aff88e4f50d7b1abbed6/lib/semverse/constraint.rb#L203-L206. Hrm. Then I'm really not sure how berkshelf/berkshelf#1135 is happeneing...