Syntax check should use active version of Ruby

berkshelf / ridley

A reliable Chef API client with a clean syntax

Other

230 stars 84 forks source link

Syntax check should use active version of Ruby #277

Closed reset closed 10 years ago

reset commented 10 years ago

When we perform a syntax check we should use the current active version of Ruby. It appears that it is possible for the syntax checker to shell out to a different version of Ruby depending on the system it is running on.

See: https://github.com/berkshelf/berkshelf/issues/1139#issuecomment-54366816

mattgleeson commented 10 years ago

Looking closer, this might have already been fixed by https://github.com/RiotGames/ridley/commit/495d1563413c2d5ffed18a7dcbb6607b97cb6db8 ?

sethvargo commented 10 years ago

We create a new ruby VM. This can't be an issue because we don't shellout...

reset commented 10 years ago

@sethvargo ah yeah, we used to shell out many versions ago. My mistake!