Temp file and directory leakage

stevendanna commented 9 years ago

Filing this here per @sethvargo's request in https://github.com/berkshelf/berkshelf/issues/1333.

I don't have a reproduction case using only Ridley. However, berks upload and berks install both appear to leak temporary files and directories. The original berkshelf bug report follows for your convenience:

Using berks 3.1.5 on Linux, a number of temporary directories and files are left behind after a berks upload:

/tmp/d20141103-6368-d03f9b:
02aa58fccaecc13d9d187ed3b0cca6eeb56c9893b6070e5636a634445f0f8311  508ae079750be4ce374c4dd6ba0342d94e311893d3f63cca651391be63e1d2d2  c7af795b9aaad7f5c97b9be30f00e1db3b7f1b9087cab40644c9ee23b53e7621
02c041898338ff3c5eb964bf4ac1aabf011b2440e56c5577baa0cffdcc074fa6  58a4b06ae32714ebcf1dd06e832d18843ebecb0ac0550e80645cffd08eea0c2d  cd5e8a35861c67f75a7c1849e01ca184f78ca80d082378a35c795040031e1a84
14b3672767eb7f2f1a05b9d8408c79f8a5edcdd5198d584d452d057cc4012fe6  5934373b15743ba7202f3b0fa496f162f15f1170d56c38480d69f6f098684f44  d611902de71fa6ccbac8fb561ebbaea512ab4c1f177e2f1e4f26e1c0c761e713
1e68ed441becf889c0b6b377133f9aa812d906447f5882417bfe9daea53e3779  6a15ca3e6d085a2c255aa070b514c402079bcd060f967af20d05a57f22e421cc  d78048fcc4f8ad445e15852e82edf8277124b521c318edcb42ef10c387887c0e
34eb8105e6f618ae3834ea9b1dbf870771dc2d0d710bbb31d7a52c1fcc349ce5  808586c6768ab4c5dade7620bc35714d5ec3ebca57af1998c103ea9269ee6577  dff14ccb7df45e0c3b0f6b3122044b39748c4092f9f04322336e17bef5e1f54e
381c07d2d0378ff19a638cc3865ad7ce06a21bf6e9f286d233079a0570919a4b  a2d09cae85cfc1dc1f0c07a2c1cbf63696889457926241f1e2aeaa2efe1c72bd  edfe384817124a198b4d16fcd2f0a4429d25ef43cbe495a1f5cc02d9b86e2277
40969acfa636d5dbdec766dd0d81fe23085bb96cb7a059b5f4ad3f26de5b0616  c50ec1a94b5d19676d66d761324ea8eeac5e692fb3934bcfcb49d035082ab986

/tmp/d20141103-6368-e8dz0n:
08229ed834ceb590e39a36e491a37e5dfbde0927209e397d9431c2062601c470  7c8408bb928dc2aa9fb4ff5f8d4b0d05b2591c64c1afc49c3283b56e5234faa7  d439491ccd6d7d8bd5369295313272bf420668bc1bb0a0763f8dc0f5b0f4eebe
12d3d95fd60a6fc454f667b3379ed0d946fafeeb63a0af67be0f2338f4ac2d65  9a42b72925985a514d44d83bb5ec0f6691d0a3c3057c050a905862e032b1563f  e70879594336dabc6ba4ef588ef484ed86d9c6c2aa21bbafa078bcad684dd1b2
453564797de35f52eba7ea00fc6ff30e342ab8e97f69847fa025effce701f0e9  b6049ef8255a2b6647d72211018bd2356f7a4bc24b6c7b1c9658ca8197813c7b
6ed2e51796de22c4e6db6ab7ca5eaf956e47d679cdc118212448bb7c6308a7c6  c21ca814a176378a5684af658b0b933ddbe65253da4712193039d8b6e3b4e007

I've confirmed with strace(1) that the berks process is creating these files and not cleaning them up. berks install leaves behind empty directories:

drwx------. 2 sdanna sdanna 40 Nov  3 19:36 /tmp/d20141103-7047-177y7aa
drwx------. 2 sdanna sdanna 40 Nov  3 19:36 /tmp/d20141103-7047-1osi4yi
drwx------. 2 sdanna sdanna 40 Nov  3 19:36 /tmp/d20141103-7047-1t1e3z2
drwx------. 2 sdanna sdanna 40 Nov  3 19:36 /tmp/d20141103-7047-2saw2t
drwx------. 2 sdanna sdanna 40 Nov  3 19:36 /tmp/d20141103-7047-o40hoq
drwx------. 2 sdanna sdanna 40 Nov  3 19:36 /tmp/d20141103-7047-rg7dsr

Again, confirmed with strace.

sethvargo commented 9 years ago

Thanks!

poliva83 commented 9 years ago

@sethvargo I thought this was fixed by https://github.com/RiotGames/ridley/pull/276

lamont-granquist commented 7 years ago

no updates in nearly 2 years, so closing as presumably fixed by #276

berkshelf / ridley

Temp file and directory leakage #286