Fix #285: Call path proc before expanding

berkshelf / ridley

A reliable Chef API client with a clean syntax

Other

231 stars 85 forks source link

Fix #285: Call path proc before expanding #295

Closed brandt closed 9 years ago

brandt commented 9 years ago

Fixes error described in issue #285

File.expand_path expects a String, but by default @options[:client_key] is a Proc. So we need to call the proc before expanding the path.

legal90 commented 9 years ago

Is there anybody who cares about this bug? It is really annoyed a lot of people who uses Berkshelf and Berkshelf API. Please, review and merge :worried:

brandt commented 9 years ago

If this is getting held up because of the red build -- pretty sure it'll be green if re-run now that #296 has been merged.

reset commented 9 years ago

@brandt yep, this wasn't merged because of the red build

reset commented 9 years ago

Released in 4.1.2

brandt commented 9 years ago

@reset sweet, thanks!