Upgrade of retryable dependency to new major version doesn't seem to be a patch release

berkshelf / ridley

A reliable Chef API client with a clean syntax

Other

231 stars 85 forks source link

Upgrade of retryable dependency to new major version doesn't seem to be a patch release #302

Closed oleg-z closed 9 years ago

oleg-z commented 9 years ago

After upgrade of ridley gem to latest patch version was surprised to see that my app doesn't start anymore because of conflict of 'retryable' gem

Not sure is it actually a bug but it just doesn't seem right. Feel free to close it

sethvargo commented 9 years ago

https://github.com/RiotGames/ridley/issues/299

reset commented 9 years ago

@oleg-z yes, this is still a patch release. Bumping one of the versions of our dependencies doesn't change our public API in anyway, so we don't manipulate our major/minor version.

Download the latest ChefDK and you'll have all the things you need!

oleg-z commented 9 years ago

@reset I agree and that's why I mentioned that it's not actually a bug

In the same time such major gem dependency change causes problems if you build something on top of berkshelf without chefdk.

Anyway thanks for quick response