berkshelf / ridley

A reliable Chef API client with a clean syntax
Other
231 stars 85 forks source link

Use httpclient instead of net_http since it respects no_proxy. #347

Closed itmustbejj closed 8 years ago

itmustbejj commented 8 years ago

Fixes #153

Berkshelf 3.3.0 added support for the no_proxy env var, only for downloads from the public Supermarket. See: https://github.com/berkshelf/berkshelf/pull/1393/files

This PR is an extension of that work to support no_proxy for all requests with Ridley.

reset commented 8 years ago

@itmustbejj we just need to drop 1.9 from the test matrix but everything else looks good!