search

berkshelf / vagrant-berkshelf

A Vagrant plugin to add Berkshelf integration to the Chef provisioners
Other
379 stars 100 forks source link

Bring Vagrant Berkshelf up to snuff #233

Closed sethvargo closed 9 years ago

sethvargo commented 9 years ago

Issues:

PRs:

TODO:

bobziuchkovski commented 9 years ago

This is awesome. Thanks for all the improvements @sethvargo !

sethvargo commented 9 years ago

@ziuchkovski if you could given this a try, that would be great. You'll need to be running the latest version of Vagrant

reset commented 9 years ago

@sethvargo this is too big to give a proper review. A shit load of improvements I'm sure but it's hard to see with all the reorganization and reformatting. Maybe if you could take some time to drop some comments in your changes or hold off on the reformatting then @ivey and I could give you a review ;)

sethvargo commented 9 years ago

@reset I can drop some comments in. For some reason, even though I used git mv, the rename failed in the diff. The biggest changes are:

  1. Fix almost every open bug
  2. Follow proper vagrant plugin format

I'll go ahead and add some comments to the PR for clarity :smile:

reset commented 9 years ago

@sethvargo thanks man, I understand the goal very clearly and the work is very good I'm sure - as always. Since I was the author of one of the first large vagrant plugins (this one) I guess I just want to know what a "best practice" plugin looks like since that didn't exist when I wrote this ;)

sethvargo commented 9 years ago

@reset added some comments. I don't think there was a best practice back when you wrote this :smile:

reset commented 9 years ago

@sethvargo perfect, thanks so much for giving me the tour. It all looks good to me! Go ahead and merge when you're comfortable. I'll create a 4.0 release immediately afterwards.

sethvargo commented 9 years ago

:heart:

bobziuchkovski commented 9 years ago

@sethvargo I just finished provisioning a VM using today's vagrant HEAD, today's vagrant-berkshelf HEAD (post-merge of this PR), and chefdk 0.3.4-1. I used the chef_zero provisioner and everything went swimmingly.

I'm really, really thrilled about your berkshelf 3.2 file syncer changes. This marks the first time I have ever been able to just 'vagrant provision' with the vmware_workstation provider. I have always had to 'vagrant reload --provision' to workaround the deleted shelf issue. This is well and truly awesome. Thanks so much for making these improvements!