search

berkshelf / vagrant-berkshelf

A Vagrant plugin to add Berkshelf integration to the Chef provisioners
Other
378 stars 100 forks source link

gem post_install_message is misleading #299

Open kzw opened 8 years ago

kzw commented 8 years ago

Users of a vagrant plugin may not experts in gem ecosystem. Having a multi line post install message about chefdk confuses the end user who have already installed chefdk into thinking that the plugin install was not finished.

reset commented 8 years ago

@kzw we need the post installation message but I'm open to suggestions on how to make it clearer

kzw commented 8 years ago

How about post_install hook to check that chefdk is installed and only emit the message if missing?

reset commented 8 years ago

@kzw I don't think there is a way to programatically display the post install message. It's just a string that you set in the gem spec: https://github.com/berkshelf/vagrant-berkshelf/blob/master/vagrant-berkshelf.gemspec#L30-L37

kzw commented 8 years ago

@reset I am thinking of something like http://stackoverflow.com/questions/6063725/how-to-use-hooks-in-ruby-gems

reset commented 8 years ago

@kzw that works for me!