berkshelf / vagrant-berkshelf

A Vagrant plugin to add Berkshelf integration to the Chef provisioners

Other

379 stars 100 forks source link

Fix: remove Bundler for Vagrant >= 1.9.0 #311

Closed theonedemon closed 7 years ago

theonedemon commented 7 years ago

310

theonedemon commented 7 years ago

Please accept merge request

theonedemon commented 7 years ago

@thommay I change my commit for your rules

kylegoch commented 7 years ago

I'm almost positive this is not the correct way to fix #310 .

As @thommay said, removing Bundler is a bigger discussion. And this file actually hasnt changed in about 2 years.

I suspect something actually changed in the vagrant code for 1.9.0 that broke vagrant-berkshelf integration. We need to look deeper into that issue than haphazardly removing code blocks.

theonedemon commented 7 years ago

@kylegoch read changelog vagrant https://github.com/mitchellh/vagrant/blob/master/CHANGELOG.md core: Remove Bundler integration for handling internal plugins [GH-7793, GH-8000, GH-8011, GH-8031]

"Bundler.with_clean_env" only clean environment variable on run command