berkus / acme-sac

Automatically exported from code.google.com/p/acme-sac
Other
0 stars 1 forks source link

directory window behaviour is flawed #11

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
reproduce as follows:
1. open a window on a directory
2. forget that it's a directory window and edit in it for an hour.
3. realise your mistake, edit the name of the window to add the
file name, type Put and execute it.
4. resize a column.
5. realise that the last hour's work has been lost irretrievably.

expected output:
1. I would expect Put to work in a directory window if the title has been
edited (it doesn't - it could at least give a warning).
2. I would expect Undo to work in directory windows past a title change.
3. I'm not sure that resizing a directory window should re-columnate it
(p9p's acme doesn't).

this is using a reasonably recent version of acme sac under mac os.

BTW, all p9p has fixed all these issues, so it shouldn't be *too* much
trouble to find the fixes.

Original issue reported on code.google.com by rogpeppe@gmail.com on 9 Nov 2007 at 4:22

GoogleCodeExporter commented 9 years ago
1. Put doesn't work in a directory window in p9p either. I agree it should at 
least
print an error (as it does for Zerox). I'll add that. But a Putall will still
silently skip directory windows.

2. Undo does seem to work in directory windows. I don't see the bug here.

3. re-columnate after a resize was my choice. I just preferred it. 

Caerwyn

Original comment by caerw...@gmail.com on 21 Mar 2008 at 5:58

GoogleCodeExporter commented 9 years ago
On second thoughts, the Put within a directory window should work. It doesn't 
make
much sense for it not to, especially if you are providing an argument to Put.

The tricky thing is that the behavior of the window should change after the Put 
so
that further edits make the window dirty, that is, it is no longer a directory
window. But this is true only if the Put happened without an arg.

Original comment by caerw...@gmail.com on 21 Mar 2008 at 7:39

GoogleCodeExporter commented 9 years ago
fixed in r151

Original comment by caerw...@gmail.com on 2 Aug 2008 at 2:50