search

berkus / gyp

Automatically exported from code.google.com/p/gyp
0 stars 0 forks source link

Gyp should issue a warning when missing a comma #89

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago 
Take a look at this diff:

http://codereview.chromium.org/264056

gyp happily took this and created a project file for it.

Original issue reported on code.google.com by dmaclach@chromium.org on 14 Oct 2009 at 3:53

GoogleCodeExporter commented 9 years ago 
This is where eval() of the .gyp file as a Python structure bites us, since the 
missing comma gets interpreted as 
Python string concatenation.  We should probably go back to using a real JSON 
parser, although we'd have the 
trailing comma issue to deal with.  (The difference in comment style could be 
readily handled.)

Original comment by sgk@chromium.org on 21 Oct 2009 at 6:29