berkus / include-what-you-use

Automatically exported from code.google.com/p/include-what-you-use
Other
1 stars 0 forks source link

Update link dependencies for out-of-tree builds #158

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
I tried an out-of-tree build of trunk with Ninja + MSVC, and had some link 
failures.

I couldn't quite see through what the comments on individual lib lines meant, 
so I interpreted it as "known prerequisites", and updated the ones that had 
changed.

My linker doesn't care about link order, so I just threw them in as early as 
possible relative to their dependency order.

Original issue reported on code.google.com by kim.gras...@gmail.com on 5 Oct 2014 at 9:52

Attachments:

GoogleCodeExporter commented 9 years ago
Comments on individual lines mean required_libraries. And correct order is for 
required libraries to appear later in the list. For example, a lot of libraries 
require LLVMSupport and LLVMSupport doesn't require anything. That's why it is 
in the end of link libraries.

Your patch seems to be working, but I suggest following changes:
- move LLVMX86CodeGen before LLVMX86Desc because it requires X86Desc;
- move LLVMCodeGen after X86-specific libraries.

LLVMMCDisassembler is in the right place, not moving it anywhere. Corresponding 
patch is attached.

Original comment by vsap...@gmail.com on 13 Oct 2014 at 4:49

Attachments:

GoogleCodeExporter commented 9 years ago
vsapsai fixed this in r596.

Original comment by kim.gras...@gmail.com on 3 Jan 2015 at 11:29