search

berkus / include-what-you-use

Automatically exported from code.google.com/p/include-what-you-use
Other
1 stars 0 forks source link

File heading comments often don't match the filename #83

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
The C++ files have a comment heading at the top, in which a filename and a 
purpose is listed. Since the filename is a little redundant, it is quite prone 
to getting out of sync, which it has in a number of cases.  Attached is a patch 
to fix this, as well as the shell script I used to do it.

Original issue reported on code.google.com by ryan.pav...@gmail.com on 20 Nov 2012 at 7:51

Attachments:

GoogleCodeExporter commented 9 years ago 
I think that's part of LLVM's style guide, not that IWYU follows much else:
http://llvm.org/docs/CodingStandards.html#file-headers

I think we should keep it for now. But I agree it's a weird convention to have.

- Kim

Original comment by kim.gras...@gmail.com on 21 Nov 2012 at 6:06

GoogleCodeExporter commented 9 years ago 
Thanks for the patch, Ryan. Committed in r377.

Original comment by vsap...@gmail.com on 25 Nov 2012 at 10:13