search

berkus / mclinker

Automatically exported from code.google.com/p/mclinker
Other
0 stars 0 forks source link

Code review request: f0391fede6ca #133

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago 
Branch name:hexagon-staging

SHA key:  f0391fede6ca

Purpose of code changes on this branch:
To return correct flags by HexagonGNUInfo

After the review, I'll merge this branch into:
master

Original issue reported on code.google.com by khem...@codeaurora.org on 5 Apr 2013 at 6:07

GoogleCodeExporter commented 9 years ago 
Hi, Hemant,

I've reviewed patches up to Revision 8381cf5e9453
I think you can merge all patches before Revision 8381cf5e9453. (including 
Revision 8381cf5e9453)

The most top two patches are under review: 03698d272610 and f0391fede6ca

Original comment by LubaTang on 5 Apr 2013 at 6:29

GoogleCodeExporter commented 9 years ago 
Hi, Hemant,

I add 6 patches:
From Revision 552c8dd8dc0c to Revision 57f1385d3fe6

I don't know if my changes fit your need or not. Please help me to review these 
patches.

Original comment by LubaTang on 5 Apr 2013 at 8:04

GoogleCodeExporter commented 9 years ago 
Hi, Hemant,

When you have problems about my patches, you can give me a -1 and tell me why.
You can revert my patches and add your own patches.

If you don't have any problems about these patches, then you can merge the 
branch into master and then clean up this branch.

Original comment by LubaTang on 5 Apr 2013 at 8:19

GoogleCodeExporter commented 9 years ago

Original comment by pete.c...@gmail.com on 10 Sep 2013 at 8:35