Open GoogleCodeExporter opened 9 years ago
Original comment by techtonik@gmail.com
on 14 Feb 2012 at 5:06
Do we have stats how popular is unified diff view /NNNNN/patch/XXX/YYY ? I am
tempted to move the link to it into the 'Patch' column and leave side-by-side
mode linked from filename.
Original comment by techtonik@gmail.com
on 14 Feb 2012 at 5:09
Agreed with making sbs diff linked from filename, as long as you can
communicate the change to the users clearly (the View link might have to be
changed to say "Unified diff").
Regarding the raw patch link: I don't care what you do as long as copying and
pasting that link into a curl command or similar thing will download the raw
patch. I use this all the time with "hg import".
Original comment by gvanrossum@gmail.com
on 16 Feb 2012 at 8:43
I can tell from various posting on the ML and here on the tracker that some
people use the unified diff view to comment on patches and when you search the
log files for "path:/\d+/patch/\d+/\d+" it show up quite regularly.
TBH I'm not sure if it's just because of the fact that the unified diff view is
linked relative prominently through the file name. But it seems that we trained
some people to use Rietveld that way along the years.
Original comment by albrecht.andi
on 17 Feb 2012 at 4:38
May be change from "Download raw patch set" to "View raw patch set"/"View raw
diff"?
Original comment by tfar...@chromium.org
on 21 Jan 2013 at 2:23
Can we close this issue? The links were renamed in revision 256dcae5c7aa.
Guidos suggestion from comment #3 should go in a separate issue then.
Original comment by albrecht.andi
on 15 Jun 2013 at 5:41
I just need to fix style for the download links. See if "noul" style can be
removed at all and add underline None for all elements in issue-list block.
Original comment by techtonik@gmail.com
on 15 Jun 2013 at 5:02
Original issue reported on code.google.com by
techtonik@gmail.com
on 14 Feb 2012 at 5:05