berkus / rietveld

Code review tool from Guido for Django
code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

Commit-Bot didn't acknowledge valid committers' LGTMs #476

Closed GoogleCodeExporter closed 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
I don't know how to reproduce this; I think I've only seen it this one time.  
You can see the result here:
https://codereview.chromium.org/165223003/

What is the expected output? What do you see instead?
Expected: Commit-Bot not to diss three super-star, A++, uber-awesome committers 
in comments #28 and #30:
No LGTM from a valid reviewer yet. Only full committers are accepted.
Even if an LGTM may have been provided, it was from a non-committer or
a lowly provisional committer, _not_ a full super star committer.
See http://www.chromium.org/getting-involved/become-a-committer
Note that this has nothing to do with OWNERS files.
Actual: Commit-Bot complained, and didn't submit the patch.

What browser are you using?  What version? On what operating system?
Google Chrome, Version 33.0.1750.115 beta, Goobuntu.

At what URL are you accessing Rietveld?  (e.g. codereview.appspot.com)
Please note if you are using the Google Apps Labs version (e.g.
codereview.<yourdomain>).
https://codereview.chromium.org/

Google Employee (rdcronin).

Original issue reported on code.google.com by rdevlin.cronin@chromium.org on 21 Feb 2014 at 6:32

GoogleCodeExporter commented 9 years ago

Original comment by maruel@chromium.org on 21 Feb 2014 at 7:30