berkus / rietveld

Code review tool from Guido for Django
code.google.com/p/rietveld
Apache License 2.0
0 stars 0 forks source link

broken side by side diff on codereview.appspot.com #497

Open GoogleCodeExporter opened 9 years ago

GoogleCodeExporter commented 9 years ago
What steps will reproduce the problem?
1. Go to 
https://codereview.appspot.com/104700043/diff/40001/oauth2_test.go?column_width=
999
2. Look at the second hunk
3. Compare to unified diff 
https://codereview.appspot.com/104700043/patch/40001/50006?context=&column_width
=999

What is the expected output? What do you see instead?

I espect to see side by side diff that reflect all the changes, instead the 
hunk doesn't include the replacement from the changed line.

See:
 52 »       DefaultTransport = &mockTransport{

Instead of:
-   DefaultTransport = &mockTransport{
+   http.DefaultTransport = &mockTransport{

See attached screenshots.

What browser are you using?  What version? On what operating system?

Google Chrome   35.0.1916.153 (Official Build 274914) 
OS  Linux 

At what URL are you accessing Rietveld?  (e.g. codereview.appspot.com)
Please note if you are using the Google Apps Labs version (e.g.
codereview.<yourdomain>).

https://codereview.appspot.com/104700043/diff/40001/oauth2_test.go?column_width=
999

*** If you are a Google employee please say so or mail rietveld-admins@
directly. ***

proppy@google.com

Please provide any additional information below.

Original issue reported on code.google.com by pro...@google.com on 14 Jul 2014 at 6:05

Attachments: