search

berlam / awesome-switcher

Switch clients in Awesome WM with the familiar preview functionality
ISC License
98 stars 15 forks source link

Fix release_key handling when Num Lock is on #10

Closed psliwka closed 6 years ago

psliwka commented 6 years ago

Num Lock counts as a modifier key. Since at the time of running the handler mod_key1 is being pressed, #mod equals 2 in such case.

This commit removes completely #mod == 1 condition from the handler. I am not sure why was it added in the first place, but it does not make much sense from my point of view. Perhaps @berlam will know more?

The plugin seems to work flawlessly after this change.

Resolves berlam/awesome-switcher#9

berlam commented 6 years ago

I checked the last commits and the change was introduced by me during a big merge. It might be, that I had that fix inside my local setup but I do not remember why. Nonetheless, as you already said, it seems to work flawlessly and your explanation is absolutely comprehensible! It is from my point of view safe to merge. Thank you for the enhancement!