search

berlin-open-wireless-lab / DAWN

Decentralized WiFi Controller
GNU General Public License v2.0
367 stars 63 forks source link

don't kick if data rate is at threshold #232

Open HarvsG opened 1 year ago

HarvsG commented 1 year ago

Fixes #231

Flole998 commented 11 months ago

@PolynomialDivision Can this be merged please?

PolynomialDivision commented 11 months ago

I don't understand the benefit? You can just set the threshold to a higher value and it has the same effect?

Flole998 commented 11 months ago

I just checked the docs again and they describe the current behaviour. However, the log entry is misleading then as it says "below" while it should say "at or below". @HarvsG What do you think about just changing the log message?

HarvsG commented 11 months ago

Current behaviour is broken, because the default setting is a commonly used data rate, so clients are kicked uneccessarily

teohhanhui commented 3 months ago

so clients are kicked uneccessarily

Actually it seems to be intentional. From what I understand how the logic goes: If the client is at the basic rate, assume it's inactive and can be kicked. i.e. kick them so that they can roam, they will rejoin if necessary anyway? (not sure if my understanding is correct)

https://github.com/berlin-open-wireless-lab/DAWN/blob/e036905ae3a5d079f899bbe46461fc78b4566349/src/storage/datastorage.c#L566

HarvsG commented 3 months ago

so clients are kicked uneccessarily

Actually it seems to be intentional. From what I understand how the logic goes: If the client is at the basic rate, assume it's inactive and can be kicked. i.e. kick them so that they can roam, they will rejoin if necessary anyway? (not sure if my understanding is correct)

I don't think it's a safe assumption because some IoT devices do transmit at that data rate.