search

berlin / haushaltsdaten

Data visualization of Berlin's public expenditures
https://haushaltsdaten.odis-berlin.de
MIT License
8 stars 3 forks source link

Style: Improve Responsiveness of Intro and FAQ Page #32

Closed Lisa-Stubert closed 2 years ago

vercel[bot] commented 2 years ago

@Lisa-Stubert is attempting to deploy a commit to the Technologiestiftung Team on Vercel.

To accomplish this, @Lisa-Stubert needs to request access to the Team.

Afterwards, an owner of the Team is required to accept their membership request.

If you're already a member of the respective Vercel Team, make sure that your Personal Vercel Account is connected to your GitHub account.

Lisa-Stubert commented 2 years ago

@dnsos Thanks for your quick review and the hints. Everything is done and worked fine. I also changed the subtitle to '2022' instead of 'Doppelhaushalt 2022/23'. But I wonder whether it wouldn't have been better to combine the data for 2022 and 2023, i.e. to add together the same cost items and then show the expenditure for the double budget instead of just for one year. Then we would lose less information compared to just presenting one year. Maybe I can try that, I have to deal for interest anyway with how the data are uploaded to Supabase, but for now let's keep to 2022.

Lisa-Stubert commented 2 years ago

I changed the branch to WIP, because there are some content issues to do.

dnsos commented 2 years ago

@Lisa-Stubert, you're right, it's not ideal that we only have 2022 at the moment. Maybe we could combine the Doppelhaushalt like you said. A change that we we would have to make is not using haushaltsdaten_2022 view and instead use the actual table haushaltsdaten_22_23 instead.

Or alternatively we make the year selectable just like we can select the districts. There is a ticket for that: #29

I changed the branch to WIP, because there are some content issues to do.

Alright. Let me know when you want me to review again.

vercel[bot] commented 2 years ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Updated
haushaltsdaten ✅ Ready (Inspect) Visit Preview Jul 27, 2022 at 7:27AM (UTC)
Lisa-Stubert commented 2 years ago

@dnsos should be ready for review and merge now. I did a lot of restyling and content change stuff...

dnsos commented 2 years ago

Before merging, I'll need to fix some Typescript issues actually