`transition_` Action Not Run on Item Update

berlindb / core

All of the required core code

MIT License

254 stars 28 forks source link

`transition_` Action Not Run on Item Update #113

Closed spencerfinnell closed 3 years ago

spencerfinnell commented 3 years ago

transition_item() uses Query::shape_item_id(); to find the ID of an item being transitioned. If no ID can be derived from the shape then nothing further happens in the transition.

When Query::update_item() is used the transition process is never completed because Query::update_item() always unsets the primary column, ultimately causing Query::shape_item_id() to always fail.

JJJ commented 3 years ago

Confirmed.

Thinking we just re-add the item ID back on right before. What do you think?

spencerfinnell commented 3 years ago

@JJJ Yep, I agree.