search

berlindb / core

All of the required core code
MIT License
254 stars 28 forks source link

Release/2.1.0 - WIP #119

Open JJJ opened 3 years ago

JJJ commented 3 years ago

Work in progress!

szepeviktor commented 2 years ago

Once this was a gift for a WP plugin developer: https://gist.github.com/szepeviktor/ddb1bfd12d93accd318cc081637956ec

JJJ commented 2 years ago

Once this was a gift...

Yes! Berlin will absolutely benefit from exactly this kind of abstraction.

See also: #39 🤧

szepeviktor commented 2 years ago

See also: #39 🤧

I see #69 also.

szepeviktor commented 2 years ago

As this change is very big could it be named v3?

JJJ commented 2 years ago

As this change is very big could it be named v3?

I was thinking about this, too. Probably yes, IMO.

szepeviktor commented 2 years ago

On PHP 8.0

composer update
vendor/bin/phpstan analyze src/ --level=1

Please ignore _applyfilters invoked with 3 parameters.

On lower levels PHPStan will complain about PHPDoc blocks, on higher levels you get your rewards 💎 💎 💎