berlindb / core

All of the required core code
MIT License
256 stars 29 forks source link

Really Bail out in Base::is_success #142

Closed szepeviktor closed 2 years ago

szepeviktor commented 2 years ago

@JJJ You bail out everywhere except here.

        // Bail if no row exists
        if ( empty( $result ) ) {
            return false;

        // Bail if an error occurred
        if ( is_wp_error( $result ) ) {
            $this->last_error = $result;
            return false;
        }

        // No errors
        return true;
JJJ commented 2 years ago

Updating in issue/128 #143 PR - thank you @szepeviktor I appreciate it