search

berlindb / core

All of the required core code
MIT License
253 stars 27 forks source link

Issue/8 - Use 'compare_query' over 'compare'. #29

Closed JJJ closed 4 years ago

JJJ commented 4 years ago

This also makes Compare queries work correctly, again.

Fixes #8.

ashleyfae commented 4 years ago

Not directly related to your work here, but very much related to "making Compare queries work":

There are some naming inconsistencies with the compare class. The class itself is named BerlinDB\Database\Queries\Compare_Query. https://github.com/berlindb/core/blob/fc304be9f47784ad0f22e4c898c3ea202ef694ee/compare.php#L25

But then in the Query class it's referenced as BerlinDB\Database\Queries\Compare. https://github.com/berlindb/core/blob/fc304be9f47784ad0f22e4c898c3ea202ef694ee/query.php#L668

But then there's also at least one place where it's not namespaced properly: https://github.com/berlindb/core/blob/fc304be9f47784ad0f22e4c898c3ea202ef694ee/query.php#L665

JJJ commented 4 years ago

@ashleyfae 👍 I'll open a new issue for that. Thanks for noticing and commenting here.