Begin removal of WP_Meta_Query dependency

berlindb / core

All of the required core code

MIT License

255 stars 29 forks source link

Begin removal of WP_Meta_Query dependency #44

Closed JJJ closed 4 years ago

JJJ commented 4 years ago

Berlin has always depended on WP_Meta_Query. This was simply due to lack of time when pushing to projects that depended on Berlin for their database table management.

We can incrementally begin this task by creating our own Queries\Meta class that extends WP_Meta_Query with no additional changes.

That will ensure that all future versions of Berlin will already be using the new class path, namespace, and are including the eventual meta.php file.

JJJ commented 4 years ago

This is potentially a breaking change for anyone using or extending Queries\Compare_Query which has now been renamed to Queries\Compare related to #8.

I suspect the audience of people doing this to be next-to-zero, but if I'm wrong we can use class_alias() to shim in some backwards compatibility for the old class name. Feel free to create a new issue and reference this comment if that is the case. Thanks! 💙