berlindb / core

All of the required core code
MIT License
254 stars 28 forks source link

'id' column hardcoded in a few places #94

Closed JJJ closed 3 years ago

JJJ commented 3 years ago

There are a few places where the id column is hardcoded as the default.

These are relics from initial database table table designs, and not intended.

While it is currently recommended that id be used as the default/primary column, it should not be a requirement. This is especially important for meta-data tables, which traditionally prefer meta_id over id for historical reasons.

See...

https://github.com/berlindb/core/blob/244bb15d7ec1efd9c67460d9db98fe371bc7e373/query.php#L307-L308

https://github.com/berlindb/core/blob/244bb15d7ec1efd9c67460d9db98fe371bc7e373/query.php#L438-L456

https://github.com/berlindb/core/blob/244bb15d7ec1efd9c67460d9db98fe371bc7e373/query.php#L1436-L1444