search

berlindb / core

All of the required core code
MIT License
254 stars 28 forks source link

Fix types #96

Closed szepeviktor closed 3 years ago

szepeviktor commented 3 years ago

I've started fixing types using @PHPStan.

But to be strictly typed we need will! How about that?

JJJ commented 3 years ago

Many good improvements here.

I'd like to keep the ABSPATH checks on a single line, please.

szepeviktor commented 3 years ago

I do not have problems with it. You know I do this to practice using @phpstan and to blow off steam from client projects. So I close this one.

JJJ commented 3 years ago

@szepeviktor 🤕 No reason to close it. Everything else was good!

szepeviktor commented 3 years ago

I know. But @phpstan sees defined( 'ABSPATH' ) || exit; as left side is always true.

szepeviktor commented 3 years ago

Anyone may continue this work! :)

And there is

parameters:
    dynamicConstantNames:
        - ABSPATH