search

berlinguyinca / spectra-hash

The splash, this is the reference documentation
http://splash.fiehnlab.ucdavis.edu
BSD 3-Clause "New" or "Revised" License
23 stars 11 forks source link

Updated scaling for splash hash in R package #12

Closed sneumann closed 8 years ago

sneumann commented 9 years ago

Hi, passes test of 409 out of 410 hashes in the test set, still working on the last one.

ssmehta commented 9 years ago

On line 21, try changing

peaks[,2] <- as.integer(peaks[,2] / max(peaks[,2]) * RELATIVE_INTENSITY_SCALE)

to

peaks[,2] <- as.integer(peaks[,2] / max(peaks[,2]) * RELATIVE_INTENSITY_SCALE + EPS_CORRECTION)
sneumann commented 8 years ago

Excellent @bhajunsingh , that did it. Cleaning up now, ETA 2hrs.

berlinguyinca commented 8 years ago

Great! Glad it worked now. On Oct 26, 2015 11:24 PM, "sneumann" notifications@github.com wrote:

Excellent @bhajunsingh https://github.com/bhajunsingh , that did it. Cleaning up now, ETA 2hrs.

— Reply to this email directly or view it on GitHub https://github.com/berlinguyinca/spectra-hash/pull/12#issuecomment-151387453 .

sneumann commented 8 years ago

Ok, package cleaned up, renamed to splashR, passing all tests. I'd say we call it verified now :-)